Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Connector API] Fix bug with nullable tooltip field in parser #103427

Merged
merged 2 commits into from
Dec 14, 2023
Merged

[Connector API] Fix bug with nullable tooltip field in parser #103427

merged 2 commits into from
Dec 14, 2023

Conversation

jedrazb
Copy link
Member

@jedrazb jedrazb commented Dec 14, 2023 •
edited
Loading

Bug description

  • According to connector protocol the tooltip field is defined as string
  • Looking at native connectors config declaration in Kibana (code ref) tooltip can also be a null which was causing issues with the connector configuration parser when updating or reading the connector configuration

Changes

  • Mark tooltip field as nullable field in class definition and in parser
  • Add unit and e2e test cases to make sure that we handle null values in the payload correctly

@elasticsearchmachine
Copy link
Collaborator

Hi @jedrazb, I've created a changelog YAML for you.

@jedrazb jedrazb marked this pull request as ready for review December 14, 2023 10:49
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ent-search-eng (Team:Enterprise Search)

@jedrazb jedrazb added the auto-backport-and-merge Automatically create backport pull requests and merge when ready label Dec 14, 2023
@jedrazb
Copy link
Member Author

jedrazb commented Dec 14, 2023

@elasticsearchmachine run elasticsearch-ci/part-4

@jedrazb jedrazb merged commit 029d42b into elastic:main Dec 14, 2023
15 checks passed
jedrazb added a commit to jedrazb/elasticsearch that referenced this pull request Dec 14, 2023
@jedrazb
[Connector API] Fix bug with nullable tooltip field in parser (elasti…
2c63f22 
…c#103427)
@jedrazb jedrazb mentioned this pull request Dec 14, 2023
Merged
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 8.12

elasticsearchmachine pushed a commit that referenced this pull request Dec 14, 2023
@jedrazb
[Connector API] Fix bug with nullable tooltip field in parser (#103427)…
3536142 
… (#103459)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timgrein timgrein timgrein approved these changes

Assignees
No one assigned
Labels
auto-backport-and-merge Automatically create backport pull requests and merge when ready >bug :EnterpriseSearch/Application Enterprise Search Team:Enterprise Search Meta label for Enterprise Search team v8.12.0 v8.12.1 v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jedrazb @elasticsearchmachine @timgrein