Add support for Well Known Binary (WKB) in the fields API for spatial fields #103461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iverase
added
>enhancement
:Analytics/Geo
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
|
Hi @iverase, I've created a changelog YAML for you. |
craigtaverner
approved these changes
Dec 15, 2023
There was a problem hiding this comment.
Nice feature. Two concerns that I don't think block this but wanted to raise:
- What is the surface of this? I saw no integration tests, and am not sure how to test this at that level. Yaml tests would expect text to compare, so that seems unfeasible.
- It only supported LITTLE_ENDIAN binary, but I noticed one test was using both little and big-endian for WKB parsing, and you removed that. I wonder if we should think more about this and add support for both endians?
server/src/test/java/org/elasticsearch/index/mapper/GeoPointFieldTypeTests.java
Show resolved
Hide resolved
...t/java/org/elasticsearch/xpack/spatial/index/mapper/GeoShapeWithDocValuesFieldTypeTests.java
Show resolved
Hide resolved
javanna
pushed a commit
to javanna/elasticsearch
that referenced
this pull request
Dec 21, 2023
navarone-feekery
pushed a commit
to navarone-feekery/elasticsearch
that referenced
this pull request
Dec 22, 2023
11 tasks
jbaiera
pushed a commit
to jbaiera/elasticsearch
that referenced
this pull request
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently support json, wkt and mvt types. It is trivial to add support for WKB which can help uses cases that works in binary formats like CBOR or SMILE.