Downsampling supports date_histogram with tz #103511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comes with caveats, for downsampled indexes at intervals more than 15 minutes. For instance, - 1-hour downsampling will produce inaccurate results for 1-hour histograms on timezones shifted by XX:30 - 1-day downsampling will produce inaccurate daily histograms for not-UTC timezones as it tracks days at UTC. Related to elastic#101309
kkrik-es
added
>bug
Team:Analytics
|
Hi @kkrik-es, I've created a changelog YAML for you. |
|
@elasticsearchmachine run elasticsearch-ci/part-4 |
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
|
Hi @kkrik-es, I've updated the changelog YAML for you. |
elasticsearchmachine
added
needs:triage
elasticsearchmachine
removed
the
needs:triage
|
@martijnvg this has been updated to offset buckets and tag responses when this happens. Ptal. |
martijnvg
reviewed
Jan 15, 2024
.../org/elasticsearch/search/aggregations/bucket/histogram/DateHistogramAggregationBuilder.java
Show resolved
Hide resolved
.../org/elasticsearch/search/aggregations/bucket/histogram/DateHistogramAggregationBuilder.java
Show resolved
Hide resolved
...n/downsample/src/main/java/org/elasticsearch/xpack/downsample/TransportDownsampleAction.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/metadata/IndexMetadata.java
Outdated
Show resolved
Hide resolved
...ample/qa/rest/src/yamlRestTest/resources/rest-api-spec/test/downsample/30_date_histogram.yml
Show resolved
Hide resolved
💔 Backport failed
You can use sqren/backport to manually backport by running |
This was referenced Jan 16, 2024
costin
pushed a commit
to costin/elasticsearch
that referenced
this pull request
Jan 17, 2024
* Downsampling supports date_histogram with tz This comes with caveats, for downsampled indexes at intervals more than 15 minutes. For instance, - 1-hour downsampling will produce inaccurate results for 1-hour histograms on timezones shifted by XX:30 - 1-day downsampling will produce inaccurate daily histograms for not-UTC timezones as it tracks days at UTC. Related to elastic#101309 * Update docs/changelog/103511.yaml * test daylight savings * update documentation * Offset time buckets over downsampled data with TZ * Update docs/changelog/103511.yaml * check for TSDS * fixme for transport version * add interval to index metadata * add transport version * bump up transport version * address feedbcak * spotless fix
jedrazb
pushed a commit
to jedrazb/elasticsearch
that referenced
this pull request
Jan 17, 2024
* Downsampling supports date_histogram with tz This comes with caveats, for downsampled indexes at intervals more than 15 minutes. For instance, - 1-hour downsampling will produce inaccurate results for 1-hour histograms on timezones shifted by XX:30 - 1-day downsampling will produce inaccurate daily histograms for not-UTC timezones as it tracks days at UTC. Related to elastic#101309 * Update docs/changelog/103511.yaml * test daylight savings * update documentation * Offset time buckets over downsampled data with TZ * Update docs/changelog/103511.yaml * check for TSDS * fixme for transport version * add interval to index metadata * add transport version * bump up transport version * address feedbcak * spotless fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comes with caveats, for downsampled indexes at intervals more than 15 minutes. For instance,
For more details, see Option 4 in Downsampling and timezones doc.
Fixes #101309