ESQL: allow null in date math
#103610
ESQL: allow null in date math
#103610
Conversation
This fixes `null`'s handling in date math. So far the `null` (of type NULL) has been rejected by the type resolution. This is now allowed through, leading to a `null` result, inline with the other types.
bpintea
added
>bug
auto-backport-and-merge
|
Documentation preview: |
|
Hi @bpintea, I've created a changelog YAML for you. |
elasticsearchmachine
added
the
Team:QL (Deprecated)
|
Pinging @elastic/es-ql (Team:QL) |
|
Pinging @elastic/elasticsearch-esql (:Query Languages/ES|QL) |
wchaparro
added
the
Team:Analytics
elasticsearchmachine
removed
the
Team:QL (Deprecated)
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
| @@ -177,6 +177,10 @@ public static boolean isDateTime(DataType type) { | |||
| return type == DATETIME; | |||
| } | |||
|
|
|||
| public static boolean isNullOrDateTime(DataType type) { | |||
There was a problem hiding this comment.
Since there's already EsqlDataTypes I would remove this method.
Zooming out a bit having both isType and isNullOrType is confusing ? if the null check is so common, why not do it in a generic way instead of having different method variants.
There was a problem hiding this comment.
👍
There's also isNullOrNumeric(), so i kept the style, but in fact this method's no longer needed, so I removed it.
bpintea
added
the
auto-merge
💔 Backport failed
You can use sqren/backport to manually backport by running |
This fixes `null`'s handling in date math. So far the `null` (of type `NULL`) has been rejected by the type resolution. This is now allowed through, leading to a `null` result, inline with the other types. Fixes elastic#103085.
This fixes
null's handling in date math. So far thenull(of typeNULL) has been rejected by the type resolution. This is now allowed through, leading to anullresult, inline with the other types.Fixes #103085.