Add index mapping parameter for counted_keyword #103646
Conversation
With this commit we add a new mapping parameter `index` to the `counted_keyword` mapping type. This allows to reduce disk usage for use cases where indexed fields are not required. Relates elastic#101826
danielmitterdorfer
added
>enhancement
:Analytics/Aggregations
|
Hi @danielmitterdorfer, I've created a changelog YAML for you. |
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
| @@ -49,3 +66,20 @@ setup: | |||
| - match: { aggregations.event_terms.buckets.2.key: "c" } | |||
| - match: { aggregations.event_terms.buckets.2.doc_count: 2 } | |||
| - length: { aggregations.event_terms.buckets: 3 } | |||
|
|
|||
| # although the field is not indexed, the counted_terms agg should still work | |||
| - do: | |||
There was a problem hiding this comment.
Maybe also verify that no inverted index is created for the events field in test-event-no-index index? Maybe by executing a field caps api call and/or disk usage api call and verify the response?
There was a problem hiding this comment.
Good point! I've also split the test case files for the default options and for index: false as the latter will be introduced in 8.13 + it keeps the two cases neatly separated.
| @@ -78,16 +78,24 @@ public class CountedKeywordFieldMapper extends FieldMapper { | |||
| public static final String CONTENT_TYPE = "counted_keyword"; | |||
| public static final String COUNT_FIELD_NAME_SUFFIX = "_count"; | |||
|
|
|||
| public static final FieldType FIELD_TYPE; | |||
| private static final FieldType FIELD_TYPE_INDEXED; | |||
There was a problem hiding this comment.
Maybe also update the CountedKeywordFieldMapperTests test case to have a test similar to KeywordFieldMapperTests$testDisableIndex()?
There was a problem hiding this comment.
Added in 47732ce.
With this commit we add a new mapping parameter `index` to the `counted_keyword` mapping type. This allows to reduce disk usage for use cases where indexed fields are not required. Relates elastic#101826
With this commit we add a new mapping parameter
indexto thecounted_keywordmapping type. This allows to reduce disk usage for use cases where indexed fields are not required.Relates #101826