[ML] Ensure unique IDs between inference models and trained model deployments #103996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core (Team:ML) |
|
Hi @maxhniebergall, I've created a changelog YAML for you. |
mark-vieira
approved these changes
Jan 5, 2024
davidkyle
reviewed
Jan 8, 2024
...-tests/src/javaRestTest/java/org/elasticsearch/xpack/ml/integration/ModelIdUniquenessIT.java
Outdated
Show resolved
Hide resolved
...-tests/src/javaRestTest/java/org/elasticsearch/xpack/ml/integration/ModelIdUniquenessIT.java
Outdated
Show resolved
Hide resolved
jbaiera
pushed a commit
to jbaiera/elasticsearch
that referenced
this pull request
Jan 10, 2024
…loyments (elastic#103996) * Check for conflciting inference models before starting trained model deployment * ensure inference model ids and trained model deployment ids are unique * Added integration test and refactored integration tests to share superclass * Update docs/changelog/103996.yaml * Add inference plugin to ml support BaseMlIntegTestCase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inference service uses trained model deployments to access in-cluster models. The inference service ID for these models is the inference service
modelId, which is mapped todeploymentIdin the trained models API. To avoid bugs due to conflicting IDs, this change restricts thePutInferenceModelActionand theStartTrainedModelDeploymentActionto unique IDs.I also refactored the ml-inference-service-tests integration tests to use a shared base class which contains methods used by multiple subclasses.
closes https://github.com/elastic/ml-team/issues/1094