Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serverless scopes for Connector APIs #104063

Merged
merged 2 commits into from Jan 9, 2024

Conversation

jedrazb
Copy link
Member

@jedrazb jedrazb commented Jan 8, 2024

This PR adds the public scope to the rest handlers used for Connector/SyncJob APIs.

This is similar change to: #95543

@jedrazb jedrazb added >enhancement :EnterpriseSearch/Application Enterprise Search Team:Enterprise Search Meta label for Enterprise Search team v8.13.0 labels Jan 8, 2024
@elasticsearchmachine
Copy link
Collaborator

Hi @jedrazb, I've created a changelog YAML for you.

@jedrazb jedrazb marked this pull request as ready for review January 8, 2024 18:22
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ent-search-eng (Team:Enterprise Search)

Copy link
Contributor

@timgrein timgrein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just curious: is this the only PR you need for enabling this API in serverless or do you also need to enable something in the serverless-repo?

@jedrazb
Copy link
Member Author

jedrazb commented Jan 9, 2024

@timgrein I don't think we need to enable things in serverless-repo. Since we don't use system indices as of now, we don't need to enable fast refresh in serveless. But this is a TODO for a future, I will ticket it. I search for "synonyms" and "query_rules" and this is the only thing that came up. Also, I don't think we use any other ES special features by our API.

@jedrazb jedrazb merged commit 82a5d66 into elastic:main Jan 9, 2024
15 checks passed
jbaiera pushed a commit to jbaiera/elasticsearch that referenced this pull request Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement :EnterpriseSearch/Application Enterprise Search Team:Enterprise Search Meta label for Enterprise Search team v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants