Correct profiled rewrite time for knn with a pre-filter #104150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benwtrent
added
>bug
:Search/Search
|
Hi @benwtrent, I've created a changelog YAML for you. |
|
Pinging @elastic/es-search (Team:Search) |
carlosdelest
approved these changes
Jan 9, 2024
|
@elasticmachine update branch |
benwtrent
added
the
auto-merge
|
@elasticmachine update branch |
jedrazb
pushed a commit
to jedrazb/elasticsearch
that referenced
this pull request
Jan 17, 2024
kNN profiling will fire multiple rewrite actions in a row without stopping a previous one. Right now, this means in production, the rewrite times are inaccurate for knn with a prefilter as we inaccurately calculate the total time (prefilter rewrite & knn rewrite). This adjusts the interface for rewriting timing to allow concurrent rewriters which then each can update the total rewrite time that we return to the user. Relates to: elastic#104131
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kNN profiling will fire multiple rewrite actions in a row without stopping a previous one. Right now, this means in production, the rewrite times are inaccurate for knn with a prefilter as we inaccurately calculate the total time (prefilter rewrite & knn rewrite).
This adjusts the interface for rewriting timing to allow concurrent rewriters which then each can update the total rewrite time that we return to the user.
Relates to: #104131