Better handling of async processor failures #104289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joegallo
added
>bug
WIP
:Data Management/Ingest Node
If the markItemAsFailed calls happen asynchronously, then the items are recorded in the BulkRequestModifier's itemResponses ArrayList in a different order than one might otherwise expect.
I think this is faster than the original code, too, because instead of N inserts on an ArrayList that need to push items out of the way, we do a single scan through all the items.
joegallo
force-pushed
the
better-handling-of-async-processor-failures
branch
from
7ea5178
to
b01b841
Compare
|
Pinging @elastic/es-data-management (Team:Data Management) |
|
Hi @joegallo, I've created a changelog YAML for you. |
joegallo
requested review from
andreidan and
masseyke
and removed request for
andreidan
andreidan
approved these changes
Jan 18, 2024
joegallo
added
auto-backport-and-merge
joegallo
added a commit
to joegallo/elasticsearch
that referenced
this pull request
Jan 25, 2024
joegallo
added a commit
to joegallo/elasticsearch
that referenced
this pull request
Jan 25, 2024
joegallo
added a commit
to joegallo/elasticsearch
that referenced
this pull request
Jan 25, 2024
joegallo
added a commit
that referenced
this pull request
Jan 25, 2024
joegallo
added a commit
that referenced
this pull request
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #101921
The
BulkRequestModifierassumes itsitemResponsesare in order, but with async processors theitemResponsescan actually be in any order.itemResponsesare for recording "failures" (i.e. a processor threw an exception, a document was dropped via adropprocessor, a document was failed via afailprocessor), and asynchronous failures can throw the ordering off. Each response initemResponsestracks its own slot, however, so recreating the correct order is not difficult.