Revert "x-pack/plugin/apm-data: download geoip DB on pipeline creation" #104505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axw
added
>bug
:Data Management/Ingest Node
|
@axw please enable the option "Allow edits and access to secrets by maintainers" on your PR. For more information, see the documentation. |
elasticsearchmachine
added
external-contributor
|
Hi @axw, I've created a changelog YAML for you. |
|
Pinging @elastic/es-data-management (Team:Data Management) |
simitt
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #104501
Per discussion Slack, we should avoid eagerly downloading this for all users. The plugin is disabled at the moment, but we intend to enable it by default at some point. This does mean that enrichment will be skipped for initial documents, but we consider this to be acceptable. If users want different behaviour, they can enable eager geoip DB downloads.