Reduce usage of Client utils with remote clusters #104552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In practice almost all of the utility methods on `Client` are only used on the local node, and many of them are untested, or positively do not work, when targetting a remote cluster (see elastic#100111). This commit removes most of the remaining usages of these utility methods against remote clusters as a step towards separating the remote-cluster client from the local-node client. Relates elastic#104536
DaveCTurner
added
>non-issue
:Core/Infra/Transport API
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In practice almost all of the utility methods on
Clientare only usedon the local node, and many of them are untested, or positively do not
work, when targetting a remote cluster (see #100111). This commit
removes most of the remaining usages of these utility methods against
remote clusters as a step towards separating the remote-cluster client
from the local-node client.
Relates #104536