Create fail points for testing #104668
Open
Create fail points for testing #104668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
needs:triage
DiannaHohensee
force-pushed
the
2024/01/23/fail-points
branch
2 times, most recently
from
364c9ff
to
51a0f74
Compare
DiannaHohensee
force-pushed
the
2024/01/23/fail-points
branch
from
51a0f74
to
591f470
Compare
DiannaHohensee
added
:Distributed/Distributed
|
Pinging @elastic/es-distributed (Team:Distributed) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that java compilers are smart enough to optimize away the fail point code blocks in production code where the ENABLED flag is always false, but I haven't confirmed that.