Add Symbol for more efficient de/serialization for use with NamedWritables #104738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
the
needs:triage
mosche
force-pushed
the
zero-copy-NamedWriteable
branch
from
0b9a041
to
d79880f
Compare
mosche
force-pushed
the
zero-copy-NamedWriteable
branch
from
d79880f
to
4f66f42
Compare
mosche
added
>refactoring
and removed
needs:triage
elasticsearchmachine
added
the
needs:triage
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
elasticsearchmachine
removed
the
needs:triage
|
@original-brownbear I found some time to wrap this up and polish things a bit. This should be ready now. WDYT? |
|
@elasticmachine update branch |
|
buildkite test this |
|
@elasticmachine update branch |
mosche
added
v8.14.1
auto-backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symbols are somewhat similar to inlined strings, but binary encoded. Once created for any relevant ASCII constant, a
Symbolcan be looked up either by name or by a range of bytes by means of the respective murmur3 hash code.Leveraging this, allocations can typically be avoided when reading a
Symbolfrom aStreamInputgiven required bytes are already buffered. When writing aSymbol, bytes can be written as is without doing any encoding work on the thread local byte buffer.