Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support enrich coordinator mode #104936

Merged
merged 5 commits into from Jan 31, 2024
Merged

Support enrich coordinator mode #104936

merged 5 commits into from Jan 31, 2024

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Jan 30, 2024

This change supports the enrich coordinator mode for cross-cluster queries.

@elasticsearchmachine
Copy link
Collaborator

Hi @dnhatn, I've created a changelog YAML for you.

plan = new FragmentExec(p);
} else {
plan = map(ua, child);
if (child instanceof FragmentExec) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the main change; the rest are tests.

@dnhatn dnhatn marked this pull request as ready for review January 30, 2024 17:40
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jan 30, 2024
Copy link
Contributor

@astefan astefan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
The only thing that I'd like to see more of is (maybe) IT tests with non-default enrich queries where ON and WITH are used as well.

@dnhatn
Copy link
Member Author

dnhatn commented Jan 31, 2024

The only thing that I'd like to see more of is (maybe) IT tests with non-default enrich queries where ON and WITH are used as well.

Sure, I will make this randomized in these tests. Thanks for reviewing.

@dnhatn dnhatn merged commit efc8be1 into elastic:main Jan 31, 2024
15 checks passed
@dnhatn dnhatn deleted the enrich-coordinator branch January 31, 2024 15:37
jedrazb pushed a commit to jedrazb/elasticsearch that referenced this pull request Feb 2, 2024
This change supports the enrich coordinator mode for cross-cluster queries.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants