New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support enrich coordinator mode #104936
Support enrich coordinator mode #104936
Conversation
Hi @dnhatn, I've created a changelog YAML for you. |
plan = new FragmentExec(p); | ||
} else { | ||
plan = map(ua, child); | ||
if (child instanceof FragmentExec) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the main change; the rest are tests.
Pinging @elastic/es-analytical-engine (Team:Analytics) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The only thing that I'd like to see more of is (maybe) IT tests with non-default enrich queries where ON
and WITH
are used as well.
Sure, I will make this randomized in these tests. Thanks for reviewing. |
This change supports the enrich coordinator mode for cross-cluster queries.
This change supports the enrich coordinator mode for cross-cluster queries.