Field-caps should read fields from up-to-dated shards #105153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
added
>bug
:Search/Search
elasticsearchmachine
added
Team:Search
|
Hi @dnhatn, I've created a changelog YAML for you. |
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
Pinging @elastic/es-search (Team:Search) |
|
test this please |
elasticsearchmachine
removed
the
Team:Analytics
original-brownbear
approved these changes
Feb 5, 2024
Thanks Armin. I will keep an eye on the benchmark. |
dnhatn
added
the
auto-backport-and-merge
💚 Backport successful
|
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Feb 5, 2024
I have seen scenarios in which field-caps return information from outdated shards. While this is probably acceptable for most cases, ESQL query planning relies on field-caps, potentially leading to missing data. The reason for this is that we don't check readAllowed when not acquiring a searcher for cases without a filter. I don't expect too much penalty in terms of performance with this change, but it helps avoid a subtle issue for ESQL. Closes elastic#104809
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 6, 2024
) I have seen scenarios in which field-caps return information from outdated shards. While this is probably acceptable for most cases, ESQL query planning relies on field-caps, potentially leading to missing data. The reason for this is that we don't check readAllowed when not acquiring a searcher for cases without a filter. I don't expect too much penalty in terms of performance with this change, but it helps avoid a subtle issue for ESQL. Closes #104809
|
@original-brownbear I checked the field-caps benchmark, and there have been no regressions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have seen scenarios in which field-caps return information from outdated shards. While this is probably acceptable for most cases, ESQL query planning relies on field-caps, potentially leading to missing data. The reason for this is that we don't check
readAllowedwhen not acquiring a searcher for cases without a filter. I don't expect too much penalty in terms of performance with this change, but it helps avoid a subtle issue for ESQL.Closes #104809