[Connector API] Support filtering connectors by service type and a query #105178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedrazb
added
>enhancement
:EnterpriseSearch/Application
|
Hi @jedrazb, I've created a changelog YAML for you. |
|
@elasticsearchmachine run elasticsearch-ci/part-3 |
|
Pinging @elastic/ent-search-eng (Team:Enterprise Search) |
jedrazb
force-pushed
the
connector-api-extend-list-connector-by-service-type-and-query
branch
from
d2016c6
to
59248e1
Compare
|
@elasticsearchmachine run elasticsearch-ci/bwc-snapshots |
|
@elasticsearchmachine run elasticsearch-ci/8.13.0 / bwc-snapshots |
wangch079
approved these changes
Feb 6, 2024
| "type": "list", | ||
| "description": "A comma-separated list of connector name(s) to fetch connector documents for" | ||
| }, | ||
| "service_type": { |
There was a problem hiding this comment.
Why don't we support this as a list?
There was a problem hiding this comment.
uhh that's a good question, I can change this into a list actually. I wasn't sure if we need to support filtering by multiple jobtypes?
There was a problem hiding this comment.
I'm adding support for multiple service types and merging :) it's a small change
|
@elasticsearchmachine run elasticsearch-ci/part-3 |
felixbarny
pushed a commit
to felixbarny/elasticsearch
that referenced
this pull request
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
service_typein list endpointname,index_nameanddescriptionfield