-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DSL] Introduce data stream global retention - Part 3 #105682
[DSL] Introduce data stream global retention - Part 3 #105682
Conversation
Documentation preview: |
Pinging @elastic/es-data-management (Team:Data Management) |
Investigating the bwc failures |
The bwc failures, happened because of the missing feature |
docs/reference/data-streams/lifecycle/tutorial-manage-data-stream-retention.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/data-streams/lifecycle/apis/put-global-retention.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/data-streams/lifecycle/tutorial-manage-data-stream-retention.asciidoc
Show resolved
Hide resolved
docs/reference/data-streams/lifecycle/tutorial-manage-data-stream-retention.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/data-streams/lifecycle/tutorial-manage-data-stream-retention.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/data-streams/lifecycle/tutorial-manage-data-stream-retention.asciidoc
Show resolved
Hide resolved
docs/reference/data-streams/lifecycle/tutorial-manage-data-stream-retention.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/data-streams/lifecycle/apis/delete-global-retention.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/data-streams/lifecycle/apis/delete-global-retention.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/data-streams/lifecycle/apis/put-global-retention.asciidoc
Outdated
Show resolved
Hide resolved
...ain/java/org/elasticsearch/datastreams/lifecycle/UpdateDataStreamGlobalRetentionService.java
Outdated
Show resolved
Hide resolved
@@ -1,7 +1,7 @@ | |||
--- | |||
"Explain backing index lifecycle": | |||
- skip: | |||
version: " - 8.13.99" | |||
cluster_features: ["datastream_lifecycle", "data_stream.lifecycle.global_retention"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is cool, much nicer than than specifying a numeric version. I think I need to go change a yaml test I just wrote ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I also liked it a lot, but I couldn't make it work in one test. I do not know yet why, it's in my todo list to see if it has a conflict when there is a skip with a version in the setup step :(. It looks like it works in most tests though.
docs/reference/data-streams/lifecycle/apis/get-global-retention.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/data-streams/lifecycle/apis/get-global-retention.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/data-streams/lifecycle/apis/put-global-retention.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/data-streams/lifecycle/tutorial-manage-data-stream-retention.asciidoc
Outdated
Show resolved
Hide resolved
I am leaning towards that test failure MixedClusterClientYamlTestSuiteIT » test {p0=mlt/30_unlike/Basic mlt query is not related to this PR. Because:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great tutorial btw!
Hi @gmarouli, I've updated the changelog YAML for you. Note that since this PR is labelled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@gmarouli according to this PR's labels, I need to update the changelog YAML, but I can't because the PR is closed. Please either update the changelog yourself on the appropriate branch, or adjust the labels. Specifically:
|
In this PR we introduce the API that will expose the global retention configuration and will allow users to take advantage of it.
These APIs are protected by the dedicated introduced privileges:
manage_data_stream_global_retention
or higher, which allows all operations on the global retention configurationmonitor_data_stream_retention
or higher, which allows the retrieval of the global retention configurationThis PR is not delivering the complete feature since the global retention is not used yet.
Relevant documentation: