Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Transform] Retry destination index creation #105759

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Conversation

prwhelan
Copy link
Member

For Unattended Transforms, if we fail to create the destination index on the first run, we will retry the transformation iteration, but we will not retry the destination index creation on that next iteration.

This change stops the Unattended Transform from progressing beyond the 0th checkpoint, so all retries will include the destination index creation.

Fix #105683
Relates #104146

For Unattended Transforms, if we fail to create the destination index on
the first run, we will retry the transformation iteration, but we will
not retry the destination index creation on that next iteration.

This change stops the Unattended Transform from progressing beyond the
0th checkpoint, so all retries will include the destination index
creation.

Fix elastic#105683
@elasticsearchmachine elasticsearchmachine added v8.14.0 needs:triage Requires assignment of a team area label labels Feb 23, 2024
@droberts195 droberts195 added the :ml/Transform Transform label Feb 23, 2024
@elasticsearchmachine elasticsearchmachine added Team:ML Meta label for the ML team and removed needs:triage Requires assignment of a team area label labels Feb 23, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@droberts195 droberts195 added >non-issue auto-backport-and-merge Automatically create backport pull requests and merge when ready v8.13.0 labels Feb 23, 2024
@droberts195
Copy link
Contributor

I have labelled this >non-issue on the basis that the bug only affects 8.13 and above, so this is fixing a bug in an unreleased version. If that's wrong then please relabel as >bug so that it gets a release note.

@droberts195 droberts195 added >test Issues or PRs that are addressing/adding tests >non-issue and removed >non-issue >test Issues or PRs that are addressing/adding tests labels Feb 23, 2024
Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prwhelan
Copy link
Member Author

I have labelled this >non-issue on the basis that the bug only affects 8.13 and above, so this is fixing a bug in an unreleased version. If that's wrong then please relabel as >bug so that it gets a release note.

That makes perfect sense to me

@prwhelan prwhelan merged commit f86532b into elastic:main Feb 23, 2024
14 checks passed
prwhelan added a commit to prwhelan/elasticsearch that referenced this pull request Feb 23, 2024
For Unattended Transforms, if we fail to create the destination index on
the first run, we will retry the transformation iteration, but we will
not retry the destination index creation on that next iteration.

This change stops the Unattended Transform from progressing beyond the
0th checkpoint, so all retries will include the destination index
creation.

Fix elastic#105683
Relate elastic#104146
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.13

elasticsearchmachine pushed a commit that referenced this pull request Feb 23, 2024
For Unattended Transforms, if we fail to create the destination index on
the first run, we will retry the transformation iteration, but we will
not retry the destination index creation on that next iteration.

This change stops the Unattended Transform from progressing beyond the
0th checkpoint, so all retries will include the destination index
creation.

Fix #105683
Relate #104146
Copy link
Contributor

@przemekwitek przemekwitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Good catch, Pat!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport-and-merge Automatically create backport pull requests and merge when ready :ml/Transform Transform >non-issue Team:ML Meta label for the ML team v8.13.0 v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] TransformInsufficientPermissionsIT testTransformPermissionsDeferUnattendedNoDest failing
4 participants