-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Transform] Retry destination index creation #105759
Conversation
For Unattended Transforms, if we fail to create the destination index on the first run, we will retry the transformation iteration, but we will not retry the destination index creation on that next iteration. This change stops the Unattended Transform from progressing beyond the 0th checkpoint, so all retries will include the destination index creation. Fix elastic#105683
Pinging @elastic/ml-core (Team:ML) |
I have labelled this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
That makes perfect sense to me |
For Unattended Transforms, if we fail to create the destination index on the first run, we will retry the transformation iteration, but we will not retry the destination index creation on that next iteration. This change stops the Unattended Transform from progressing beyond the 0th checkpoint, so all retries will include the destination index creation. Fix elastic#105683 Relate elastic#104146
💚 Backport successful
|
For Unattended Transforms, if we fail to create the destination index on the first run, we will retry the transformation iteration, but we will not retry the destination index creation on that next iteration. This change stops the Unattended Transform from progressing beyond the 0th checkpoint, so all retries will include the destination index creation. Fix #105683 Relate #104146
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Good catch, Pat!
For Unattended Transforms, if we fail to create the destination index on the first run, we will retry the transformation iteration, but we will not retry the destination index creation on that next iteration.
This change stops the Unattended Transform from progressing beyond the 0th checkpoint, so all retries will include the destination index creation.
Fix #105683
Relates #104146