Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assert exception type rather than message that may be influenced by locale language #105823

Merged
merged 5 commits into from Mar 9, 2024
Merged

Assert exception type rather than message that may be influenced by locale language #105823

merged 5 commits into from Mar 9, 2024

Conversation

puppylpg
Copy link
Contributor

To solve #105822

@puppylpg puppylpg requested a review from a team as a code owner February 27, 2024 08:27
@elasticsearchmachine elasticsearchmachine added v8.14.0 needs:triage Requires assignment of a team area label external-contributor Pull request authored by a developer outside the Elasticsearch team labels Feb 27, 2024
@gbanasiak gbanasiak added the :Core/Infra/Core Core issues without another label label Mar 1, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Mar 1, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Mar 1, 2024
rjernst
rjernst requested changes Mar 1, 2024
View reviewed changes
Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, just one small ask

test/framework/src/main/java/org/elasticsearch/test/readiness/ReadinessClientProbe.java Outdated Show resolved Hide resolved
@rjernst
Copy link
Member

rjernst commented Mar 1, 2024

Also can you please adjust the PR title to reflect the exception change instead of default locale?

@rjernst rjernst added the >test Issues or PRs that are addressing/adding tests label Mar 1, 2024
@rjernst rjernst self-assigned this Mar 1, 2024
@puppylpg puppylpg changed the title Configure default locale for the test cases Assert exception type rather than message that may be influenced by locale language Mar 1, 2024
@puppylpg puppylpg requested a review from rjernst March 1, 2024 13:26
@rjernst
Copy link
Member

rjernst commented Mar 1, 2024

@elasticsearchmachine ok to test

@rjernst
Copy link
Member

rjernst commented Mar 1, 2024

@elasticmachine ok to test

@rjernst
Copy link
Member

rjernst commented Mar 4, 2024

Buildkite test this

@rjernst
Copy link
Member

rjernst commented Mar 7, 2024

@elasticmachine update branch

@rjernst
Copy link
Member

rjernst commented Mar 7, 2024

Buildkite test this

rjernst
rjernst approved these changes Mar 9, 2024
View reviewed changes
Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @puppylpg!

@rjernst rjernst merged commit 58477b5 into elastic:main Mar 9, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjernst rjernst rjernst approved these changes

Assignees

@rjernst rjernst

Labels
:Core/Infra/Core Core issues without another label external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Core/Infra Meta label for core/infra team >test Issues or PRs that are addressing/adding tests v8.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@puppylpg @elasticsearchmachine @rjernst @gbanasiak @elasticmachine