Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs typo fix #105835

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Docs typo fix #105835

merged 1 commit into from
Mar 6, 2024

Conversation

MikhailBerezhanov
Copy link
Contributor

mergeing typo fixed to merging

@MikhailBerezhanov
Update index.asciidoc : mergeing typo fix
8601c5c 
`mergeing` typo fixed to `merging`
@cla-checker-service CLA Checker Service
Copy link

cla-checker-service bot commented Feb 28, 2024 •
edited
Loading

💚 CLA has been signed

@github-actions GitHub Actions
Copy link

Documentation preview:

@elasticsearchmachine elasticsearchmachine added external-contributor Pull request authored by a developer outside the Elasticsearch team needs:triage Requires assignment of a team area label v8.12.3 labels Feb 28, 2024
@MikhailBerezhanov MikhailBerezhanov marked this pull request as draft February 28, 2024 11:45
@brianseeders brianseeders added the >docs General docs changes label Mar 1, 2024
@joegallo joegallo self-assigned this Mar 4, 2024
@joegallo joegallo marked this pull request as ready for review March 4, 2024 16:22
@elasticsearchmachine elasticsearchmachine added the Team:Docs Meta label for docs team label Mar 4, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Mar 4, 2024
@joegallo
Copy link
Contributor

joegallo commented Mar 4, 2024 •
edited
Loading

Thank you for finding this, @MikhailBerezhanov! Usually we target pull requests like this against the main branch and then backport to the relevant 8.x branch (in this case 8.12), but if it's alright with you I'm happy to merge this PR as-is and then I can handle forward porting the same change to the main branch on your behalf.

Does that sound good to you?

edit: In the absence of objection, and given the simple nature of this fix, I'm just moving forward.

@joegallo joegallo added the :Data Management/Data streams Data streams and their lifecycles label Mar 4, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Data Management Meta label for data/management team label Mar 4, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@joegallo joegallo added v8.13.1 v8.14.0 auto-backport Automatically create backport pull requests when merged labels Mar 6, 2024
@joegallo joegallo changed the title Update index.asciidoc : mergeing typo fix Docs typo fix Mar 6, 2024
@joegallo joegallo merged commit bf20c12 into elastic:8.12 Mar 6, 2024
5 checks passed
This was referenced Mar 6, 2024
Merged
Merged
joegallo pushed a commit to joegallo/elasticsearch that referenced this pull request Mar 6, 2024
@MikhailBerezhanov @joegallo
Docs typo fix (elastic#105835)
ad853d3
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 8.13
✅ main

joegallo pushed a commit to joegallo/elasticsearch that referenced this pull request Mar 6, 2024
@MikhailBerezhanov @joegallo
Docs typo fix (elastic#105835)
2454e0e
joegallo added a commit that referenced this pull request Mar 6, 2024
@joegallo
Docs typo fix (#105835) (#106001)
2a48246
joegallo added a commit that referenced this pull request Mar 6, 2024
@joegallo @MikhailBerezhanov
Docs typo fix (#105835) (#106002)
3816840 
Co-authored-by: MikhailBerezhanov <35196259+MikhailBerezhanov@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joegallo joegallo joegallo approved these changes

Assignees

@joegallo joegallo

Labels
auto-backport Automatically create backport pull requests when merged :Data Management/Data streams Data streams and their lifecycles >docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team v8.12.3 v8.13.1 v8.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MikhailBerezhanov @elasticsearchmachine @joegallo @brianseeders