ProjectOperator should not retain references to released blocks #105848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
added
the
Team:Analytics
|
Hi @dnhatn, I've created a changelog YAML for you. |
|
Thanks Alex! |
dnhatn
added
the
auto-backport-and-merge
|
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Mar 3, 2024
…tic#105848) The heap attack tests hit OOM where the circuit breaker was under-accounted. This was because the ProjectOperator retained references to released blocks. Consequently, the released block couldn't be GCed although we have decreased memory usage in the circuit breaker. Relates elastic#10563
idegtiarenko
pushed a commit
to idegtiarenko/elasticsearch
that referenced
this pull request
Mar 4, 2024
…tic#105848) The heap attack tests hit OOM where the circuit breaker was under-accounted. This was because the ProjectOperator retained references to released blocks. Consequently, the released block couldn't be GCed although we have decreased memory usage in the circuit breaker. Relates elastic#10563
This was referenced Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The heap attack tests hit OOM where the circuit breaker was under-accounted. This was because the ProjectOperator retained references to released blocks. Consequently, the released block couldn't be GCed although we have decreased memory usage in the circuit breaker.
Relates #105632