Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeoIP custom endpoint cacert, Update geoip.asciidoc #105880

Closed
wants to merge 1 commit into from

Conversation

predogma
Copy link
Contributor

@predogma predogma commented Mar 1, 2024

The GeoIP endpoint does not use the xpack http client. The GeoIP downloader uses the JDKs builtin cacerts.

If customer is using custom https endpoint they need to provide the cacert in the jdk, whether our jdk bundled in or their jdk. Otherwise they will see something like

...PKiX path building failed: sun.security.provier.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target...
  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

The GeoIP endpoint does not use the xpack http client. 
The GeoIP downloader uses the JDKs builtin cacerts.

If customer is using custom https endpoint they need to provide the cacert in the jdk, whether our jdk bundled in or their jdk. Otherwise they will see something like

```
...PKiX path building failed: sun.security.provier.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target...
```
Copy link

github-actions bot commented Mar 1, 2024

Documentation preview:

@elasticsearchmachine
Copy link
Collaborator

@predogma please enable the option "Allow edits and access to secrets by maintainers" on your PR. For more information, see the documentation.

@elasticsearchmachine elasticsearchmachine added Team:Docs Meta label for docs team v8.12.3 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Mar 1, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@predogma predogma removed the external-contributor Pull request authored by a developer outside the Elasticsearch team label Mar 1, 2024
@@ -435,6 +435,8 @@ each node's <<es-tmpdir,temporary directory>> at `$ES_TMPDIR/geoip-databases/<no
Note that {es} will make a GET request to `${ingest.geoip.downloader.endpoint}?elastic_geoip_service_tos=agree`,
expecting the list of metadata about databases typically found in `overview.json`.

The GeoIP downloader uses the JDKs builtin cacerts. If custom endpoint is used add the custom https endpoint cacert(s) to the JDK's truststore.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The GeoIP downloader uses the JDKs builtin cacerts. If custom endpoint is used add the custom https endpoint cacert(s) to the JDK's truststore.
The GeoIP downloader uses the JDK's builtin cacerts. If you're using a custom endpoint, add the custom https endpoint cacert(s) to the JDK's truststore.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wording nit 🤓

@leemthompo
Copy link
Contributor

Thanks @predogma! Would you be able to target the main branch so we can backport?

@predogma
Copy link
Contributor Author

predogma commented Mar 4, 2024

Redirecting to new PR on Main, per request here

#105908

@predogma predogma closed this Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes Team:Docs Meta label for docs team v8.11.0 v8.12.0 v8.12.3 v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants