Additional trace logging for desired balance computer #105910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idegtiarenko
added
>test
|
Pinging @elastic/es-distributed (Team:Distributed) |
idegtiarenko
commented
Mar 4, 2024
| @@ -283,7 +293,6 @@ public DesiredBalance compute( | |||
| hasChanges = true; | |||
| clusterInfoSimulator.simulateShardStarted(shardRouting); | |||
| routingNodes.startShard(logger, shardRouting, changes, 0L); | |||
| logger.trace("starting shard {}", shardRouting); | |||
There was a problem hiding this comment.
Removed as it is easy to deduct shard starting from above huge log entry
DaveCTurner
approved these changes
Mar 4, 2024
| desiredBalanceInput.routingAllocation().snapshotShardSizeInfo().toString() | ||
| ); | ||
| } else { | ||
| logger.debug("Recomputing desired balance for [{}]", desiredBalanceInput.index()); |
There was a problem hiding this comment.
I think it'd be useful to see the .index() even if trace logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the following sequence of events is happening casing a test failure:
I am adding more logs to confirm this theory.
I think it is possible to fix this test either by:
cluster.snapshot.info.max_concurrent_fetcheshowever I am not sure if it is possible to avoid using outdated cluster info when allocating (with the assumptions that we want to allocate shards as fast as possible).
Related to: #105331