Adjust randomization in ResolveClusterActionResponseTests #105932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilures in testEqualsAndHashcode tests Fixes elastic#105898
quux00
added
>non-issue
:Search/Search
|
Pinging @elastic/es-search (Team:Search) |
javanna
approved these changes
Mar 5, 2024
cbuescher
approved these changes
Mar 5, 2024
| @@ -52,6 +63,6 @@ protected Writeable.Reader<ResolveClusterActionResponse> instanceReader() { | |||
|
|
|||
| @Override | |||
| protected ResolveClusterActionResponse mutateInstance(ResolveClusterActionResponse response) { | |||
| return new ResolveClusterActionResponse(randomResolveClusterInfoMap()); | |||
| return new ResolveClusterActionResponse(randomResolveClusterInfoMap(() -> randomResolveClusterInfoWithErrorString())); | |||
There was a problem hiding this comment.
This is fine, but alternatively you could use the "randomValueOtherThan" helper method from ESTestCase that randomizes until it has created an object thats not equal to the input. Might save a bit of extra code here and be a bit more readably on the long run.
There was a problem hiding this comment.
Oh, cool. Thanks for the tip. Very helpful method! I've changed the code to use on the next push.
jedrazb
pushed a commit
to jedrazb/elasticsearch
that referenced
this pull request
Mar 6, 2024
…5932) to avoid failures in `testEqualsAndHashcode` tests. Fixes elastic#105898
gmarouli
pushed a commit
to gmarouli/elasticsearch
that referenced
this pull request
Mar 6, 2024
…5932) to avoid failures in `testEqualsAndHashcode` tests. Fixes elastic#105898
fang-xing-esql
pushed a commit
to fang-xing-esql/Elasticsearch
that referenced
this pull request
Mar 8, 2024
…5932) to avoid failures in `testEqualsAndHashcode` tests. Fixes elastic#105898
quux00
added a commit
to quux00/elasticsearch
that referenced
this pull request
Mar 26, 2024
…5932) to avoid failures in `testEqualsAndHashcode` tests. Fixes elastic#105898
quux00
added a commit
that referenced
this pull request
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to avoid failures in
testEqualsAndHashcodetests.Fixes #105898