Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Connector API] Fix default ordering in SyncJob list endpoint #105945

Merged
merged 5 commits into from Mar 6, 2024
Merged

[Connector API] Fix default ordering in SyncJob list endpoint #105945

merged 5 commits into from Mar 6, 2024

Conversation

jedrazb
Copy link
Member

@jedrazb jedrazb commented Mar 5, 2024

Changes

  • Change from asc to desc ordering by sync job creation date
  • This is currently breaking UX when we list connector sync job history, most recent sync jobs are displayed at the end

@jedrazb jedrazb added >bug auto-backport-and-merge Automatically create backport pull requests and merge when ready v8.13.0 v8.14.0 :SearchOrg/Extract&Transform Label for the Search E&T team Team:Search - Extract & Transform labels Mar 5, 2024
@jedrazb jedrazb requested a review from timgrein March 5, 2024 10:25
@jedrazb jedrazb marked this pull request as ready for review March 5, 2024 10:25
@elasticsearchmachine elasticsearchmachine added the Team:Search Meta label for search team label Mar 5, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@elasticsearchmachine
Copy link
Collaborator

Hi @jedrazb, I've created a changelog YAML for you.

@jedrazb jedrazb changed the title [Connector API] Fix default oredering in SyncJob list endpoint [Connector API] Fix default ordering in SyncJob list endpoint Mar 5, 2024
@jedrazb jedrazb added :EnterpriseSearch/Application Enterprise Search Team:Enterprise Search Meta label for Enterprise Search team >bug and removed :SearchOrg/Extract&Transform Label for the Search E&T team Team:Search - Extract & Transform >bug labels Mar 5, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ent-search-eng (Team:Enterprise Search)

@elasticsearchmachine elasticsearchmachine removed the Team:Search Meta label for search team label Mar 5, 2024
timgrein
timgrein approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@timgrein timgrein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jedrazb jedrazb requested a review from a team as a code owner March 6, 2024 07:16
@jedrazb jedrazb force-pushed the connector-api-fix-bug-with-default-sync-job-ordering-list branch from 6ed6d56 to ff6890e Compare March 6, 2024 07:18
@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label and removed Team:Search - Extract & Transform labels Mar 6, 2024
@timgrein timgrein added Team:Search - Extract & Transform and removed needs:triage Requires assignment of a team area label labels Mar 6, 2024
@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label and removed Team:Search - Extract & Transform labels Mar 6, 2024
@timgrein timgrein added Team:Enterprise Search Meta label for Enterprise Search team and removed needs:triage Requires assignment of a team area label labels Mar 6, 2024
@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label and removed Team:Enterprise Search Meta label for Enterprise Search team labels Mar 6, 2024
@timgrein timgrein added Team:Enterprise Search Meta label for Enterprise Search team :SearchOrg/Extract&Transform Label for the Search E&T team and removed needs:triage Requires assignment of a team area label labels Mar 6, 2024
@elasticsearchmachine elasticsearchmachine added Team:Search Meta label for search team Team:Search - Extract & Transform and removed Team:Enterprise Search Meta label for Enterprise Search team labels Mar 6, 2024
@timgrein timgrein removed the Team:Search Meta label for search team label Mar 6, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Search Meta label for search team label Mar 6, 2024
@jedrazb jedrazb added :EnterpriseSearch/Application Enterprise Search Team:Enterprise Search Meta label for Enterprise Search team and removed Team:Search Meta label for search team :SearchOrg/Extract&Transform Label for the Search E&T team labels Mar 6, 2024
@jedrazb
Copy link
Member Author

jedrazb commented Mar 6, 2024

^ We were testing new labels for our team, merging with status quo labesls

@jedrazb jedrazb merged commit 099a5a9 into elastic:main Mar 6, 2024
14 checks passed
@jedrazb jedrazb mentioned this pull request Mar 6, 2024
Merged
jedrazb added a commit to jedrazb/elasticsearch that referenced this pull request Mar 6, 2024
@jedrazb
[Connector API] Fix default ordering in SyncJob list endpoint (elasti…
75c30d5 
…c#105945)
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 8.13

elasticsearchmachine pushed a commit that referenced this pull request Mar 6, 2024
@jedrazb
[Connector API] Fix default ordering in SyncJob list endpoint (#105945)…
a91f002 
… (#106009)
fang-xing-esql pushed a commit to fang-xing-esql/Elasticsearch that referenced this pull request Mar 8, 2024
@jedrazb @fang-xing-esql
[Connector API] Fix default ordering in SyncJob list endpoint (elasti…
6763d6e 
…c#105945)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artem-shelkovnikov artem-shelkovnikov artem-shelkovnikov approved these changes

@timgrein timgrein timgrein approved these changes

@wangch079 wangch079 wangch079 approved these changes

Assignees
No one assigned
Labels
auto-backport-and-merge Automatically create backport pull requests and merge when ready >bug :EnterpriseSearch/Application Enterprise Search Team:Enterprise Search Meta label for Enterprise Search team v8.13.0 v8.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jedrazb @elasticsearchmachine @artem-shelkovnikov @timgrein @wangch079