New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query API Key Information API support for the typed_keys
request parameter
#106873
Query API Key Information API support for the typed_keys
request parameter
#106873
Conversation
Documentation preview: |
Pinging @elastic/es-security (Team:Security) |
Hi @albertzaharovits, I've created a changelog YAML for you. |
(Optional, Boolean) If `true`, aggregation and suggester names are be prefixed | ||
by their respective types in the response. Defaults to `true`. | ||
(Optional, Boolean) If `true`, aggregation and suggester names are prefixed | ||
by their respective types in the response. Defaults to `false`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It defaults to false:
elasticsearch/server/src/main/java/org/elasticsearch/search/aggregations/InternalAggregation.java
Line 224 in 917f54a
if (params.paramAsBoolean(RestSearchAction.TYPED_KEYS_PARAM, false)) { |
elasticsearch/server/src/main/java/org/elasticsearch/search/suggest/Suggest.java
Line 296 in 917f54a
if (params.paramAsBoolean(RestSearchAction.TYPED_KEYS_PARAM, false)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…rameter (elastic#106873) The typed_keys request parameter is the canonical parameter, that's also used in the regular index _search enpoint, in order to return the types of aggregations in the response. This is required by typed language clients of the _security/_query/api_key endpoint that are using aggregations. Closes elastic#106817
…rameter (#106873) (#107110) The typed_keys request parameter is the canonical parameter, that's also used in the regular index _search enpoint, in order to return the types of aggregations in the response. This is required by typed language clients of the _security/_query/api_key endpoint that are using aggregations. Backport of #106873
The
typed_keys
request parameter is the canonical parameter,that's also used in the regular index
_search
enpoint, in order toreturn the types of aggregations in the response.
This is required by typed language clients of the
_security/_query/api_key
endpoint that are using aggregations.
Closes #106817