Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable children aggregation concurrent execution #106911

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

salvatore-campagna
Copy link
Contributor

@salvatore-campagna salvatore-campagna commented Mar 29, 2024

Parent/children aggregations are used together but only the parent
disables concurrent execution by overriding supportsParallelCollection.
This is incorrect, so we here just make sure the children is not
executed concurrently too.

This is required for #106325.

@salvatore-campagna salvatore-campagna added >bug :Analytics/Aggregations Aggregations :Search/Search Search-related issues that do not fall into other categories labels Mar 29, 2024
@salvatore-campagna salvatore-campagna self-assigned this Mar 29, 2024
@elasticsearchmachine elasticsearchmachine added Team:Search Meta label for search team Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.14.0 labels Mar 29, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@elasticsearchmachine
Copy link
Collaborator

Hi @salvatore-campagna, I've created a changelog YAML for you.

Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@martijnvg martijnvg removed the :Search/Search Search-related issues that do not fall into other categories label Apr 2, 2024
@elasticsearchmachine elasticsearchmachine removed the Team:Search Meta label for search team label Apr 2, 2024
@@ -0,0 +1,5 @@
pr: 106911
summary: Disable children aggregation concurrent execution
area: "Search, Aggregations"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just label this aggregations. Then validate changelog check will be happy.

Copy link
Member

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to add a test that fails ? Ideally we'd have the same for parent agg too, not sure we have it already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Aggregations Aggregations >bug Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants