New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable children aggregation concurrent execution #106911
base: main
Are you sure you want to change the base?
Disable children aggregation concurrent execution #106911
Conversation
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Pinging @elastic/es-search (Team:Search) |
Hi @salvatore-campagna, I've created a changelog YAML for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
docs/changelog/106911.yaml
Outdated
@@ -0,0 +1,5 @@ | |||
pr: 106911 | |||
summary: Disable children aggregation concurrent execution | |||
area: "Search, Aggregations" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just label this aggregations. Then validate changelog check will be happy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it possible to add a test that fails ? Ideally we'd have the same for parent agg too, not sure we have it already.
Parent/children aggregations are used together but only the parent
disables concurrent execution by overriding
supportsParallelCollection
.This is incorrect, so we here just make sure the children is not
executed concurrently too.
This is required for #106325.