Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move WeightedTokensQueryBuilder to the core plugin #106924

Closed
wants to merge 1 commit into from
Closed

Move WeightedTokensQueryBuilder to the core plugin #106924

wants to merge 1 commit into from
+56 −44

Conversation

Mikep86
Copy link
Contributor

@Mikep86 Mikep86 commented Mar 29, 2024

Move WeightedTokensQueryBuilder to the core plugin so that it can be used by the semantic_query query.

@Mikep86 Mikep86 added >non-issue :Search/Search Search-related issues that do not fall into other categories :Search/Vectors Vector search v8.14.0 labels Mar 29, 2024
@Mikep86 Mikep86 requested a review from a team as a code owner March 29, 2024 17:27
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@elasticsearchmachine elasticsearchmachine added the Team:Search Meta label for search team label Mar 29, 2024
@Mikep86 Mikep86 mentioned this pull request Mar 29, 2024
Merged
@benwtrent
Copy link
Member

@Mikep86 maybe wait on this. I know @kderusso is working on this right now and may move things around and rename.

@kderusso
Copy link
Member

@Mikep86 Is not having this blocking you?

@Mikep86
Copy link
Contributor Author

Mikep86 commented Mar 29, 2024

@kderusso

Is not having this blocking you?

It's not a hard blocker, but we'd like to use WeightedTokensQueryBuilder here:

elasticsearch/x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/mapper/SemanticTextFieldMapper.java

Line 300 in 417f42b

// TODO: Use WeightedTokensQueryBuilder

@Mikep86
Copy link
Contributor Author

Mikep86 commented Mar 29, 2024

This PR is on hold while @kderusso & I sync on changes she is making in the same area

@Mikep86
Copy link
Contributor Author

Mikep86 commented May 15, 2024

Closing due to overlap with #108254

@Mikep86 Mikep86 closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-vieira mark-vieira mark-vieira approved these changes

@carlosdelest carlosdelest Awaiting requested review from carlosdelest

@jimczi jimczi Awaiting requested review from jimczi

@kderusso kderusso Awaiting requested review from kderusso

Assignees
No one assigned
Labels
>non-issue :Search/Search Search-related issues that do not fall into other categories :Search/Vectors Vector search Team:Search Meta label for search team v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Mikep86 @elasticsearchmachine @benwtrent @kderusso @mark-vieira