Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query API Keys support for both aggs and aggregations keywords #107054

Merged
merged 4 commits into from Apr 3, 2024
Merged

Query API Keys support for both aggs and aggregations keywords #107054

merged 4 commits into from Apr 3, 2024

Conversation

albertzaharovits
Copy link
Contributor

The Query API Key Information endpoint supports aggs since #104895.
But some lang clients actually use the aggregations term in requests, as the preferred synonym.
This PR adds support for the aggregations request term as a synonym for the existing aggs term.

Closes #106839

@albertzaharovits albertzaharovits added >enhancement :Security/Security Security issues without another label labels Apr 3, 2024
@albertzaharovits albertzaharovits self-assigned this Apr 3, 2024
@albertzaharovits albertzaharovits marked this pull request as ready for review April 3, 2024 14:20
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2024

Documentation preview:

@elasticsearchmachine elasticsearchmachine added v8.14.0 Team:Security Meta label for security team labels Apr 3, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

@elasticsearchmachine
Copy link
Collaborator

Hi @albertzaharovits, I've created a changelog YAML for you.

@slobodanadamovic slobodanadamovic self-requested a review April 3, 2024 14:34
jakelandis
jakelandis approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@jakelandis jakelandis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@albertzaharovits albertzaharovits merged commit 36bcb6b into elastic:main Apr 3, 2024
18 checks passed
@albertzaharovits albertzaharovits deleted the query-api-key-accept-aggs-and-aggregations branch April 3, 2024 15:33
albertzaharovits added a commit to albertzaharovits/elasticsearch that referenced this pull request Apr 4, 2024
@albertzaharovits
Query API Keys support for both aggs and aggregations keywords (e…
5ab627c 
…lastic#107054)

The Query API Key Information endpoint supports aggs since elastic#104895.
But some lang clients actually use the `aggregations` keyword in requests,
as the preferred synonym to `aggs`.
This PR adds support for the `aggregations` request keyword as a synonym
for the existing `aggs` term.

Closes elastic#106839
@albertzaharovits albertzaharovits mentioned this pull request Apr 4, 2024
Merged
albertzaharovits added a commit that referenced this pull request Apr 5, 2024
@albertzaharovits
[8.13] Query API Keys support for both aggs and aggregations keyw…
2eb9729 
…ords (#… (#107108)

The Query API Key Information endpoint supports aggs since #104895.
But some lang clients actually use the aggregations term in requests, as the preferred synonym.
This PR adds support for the aggregations request term as a synonym for the existing aggs term.

Backport of #107054
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakelandis jakelandis jakelandis approved these changes

@slobodanadamovic slobodanadamovic Awaiting requested review from slobodanadamovic

Assignees

@albertzaharovits albertzaharovits

Labels
>enhancement :Security/Security Security issues without another label Team:Security Meta label for security team v8.13.2 v8.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Query API key information API only accepts "aggs" and not "aggregations"
3 participants
@albertzaharovits @elasticsearchmachine @jakelandis