ESQL: Fix version test failure on non-SNAPSHOT builds #107138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the snapshot ESQL version separately and take the current build into account.
alex-spies
added
>test
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
astefan
reviewed
Apr 5, 2024
| for (EsqlVersion version : EsqlVersion.values()) { | ||
| if (version == EsqlVersion.SNAPSHOT) { |
There was a problem hiding this comment.
I think the way to "skip" a test if some condition is not met is to use assumeTrue.
assumeTrue("Should not test snapshot version here", version != EsqlVersion.SNAPSHOT)
There was a problem hiding this comment.
Please, ignore my comment. With this approach the test will always be skipped.
|
Thanks @astefan ! |
alex-spies
deleted the
skip-snapshot-version-check-on-non-snapshot-builds
branch
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
alex-spies
added a commit
to alex-spies/elasticsearch
that referenced
this pull request
Apr 11, 2024
Test the snapshot ESQL version separately and take the current build into account. (cherry picked from commit ad77d32)
alex-spies
added a commit
that referenced
this pull request
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #107106
Test the snapshot ESQL version separately and take the current build into account.