Upgrade to lucene-5.2-snapshot-1675363. #10727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Explanation boostExpl = Explanation.match(maxBoost, "maxBoost"); | ||
| Explanation minExpl = Explanation.match( | ||
| Math.min(funcExpl.getValue(), maxBoost), | ||
| "Math.min of", |
There was a problem hiding this comment.
should we just say min of or minimum of?
|
Looks great. I think in general i prefer "min of" or "minimum of" where we currently say "Math.min of", because that only makes sense to java developers. Otherwise I am happy the equals/hashcode are all using superclass methods, and ComplexExplanation is out of here. |
|
Thanks Robert. I kept the explanation descriptions as they were but I don't mind applying the fixes you suggest. We might find more bugs in equals/hashcode as we migrate to queries which recursively call QueryUtils.check on sub queries on the contrary to filters. |
|
Indeed, they were in the CombineFunction before that way (I missed that). I thought they were newly introduced here. |
This snapshot contains in particular LUCENE-6446 (refactored explanation API) and LUCENE-6448 (better equals/hashcode for filters).
jpountz
force-pushed
the
upgrade/lucene-5.2-snapshot-1675363
branch
from
5142b60
to
dd679a3
Compare
jpountz
added a commit
that referenced
this pull request
Apr 22, 2015
…75363 Upgrade to lucene-5.2-snapshot-1675363.
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
This is backported from elastic#10727. closes elastic#10742
clintongormley
added
:Core/Infra/Core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This snapshot contains in particular LUCENE-6446 (refactored explanation API)
and LUCENE-6448 (better equals/hashcode for filters).
Closes #10728