-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the 'Anonymous IP' database to the geoip processor #107287
Merged
joegallo
merged 14 commits into
elastic:main
from
joegallo:ingest-geoip-processor-anonymous-ip
Apr 11, 2024
Merged
Add support for the 'Anonymous IP' database to the geoip processor #107287
joegallo
merged 14 commits into
elastic:main
from
joegallo:ingest-geoip-processor-anonymous-ip
Apr 11, 2024
Commits on Apr 9, 2024
-
Put the default fields for the city database in the same order as the valid fields for the city database. Interestingly, the 'TIMEZONE' (and the 'IP') are the only valid non-default properties.
Configuration menu - View commit details
-
Copy full SHA for aa380c1 - Browse repository at this point
Copy the full SHA aa380c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for d9e2326 - Browse repository at this point
Copy the full SHA d9e2326View commit details -
Configuration menu - View commit details
-
Copy full SHA for cd1f7ec - Browse repository at this point
Copy the full SHA cd1f7ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for c93df1e - Browse repository at this point
Copy the full SHA c93df1eView commit details -
Configuration menu - View commit details
-
Copy full SHA for bfb74ce - Browse repository at this point
Copy the full SHA bfb74ceView commit details
Commits on Apr 10, 2024
-
latitude and longitude are not actually usable properties
Rather, they're the object properties under which those values will be written within a containing 'location' object, if the 'location' property has been selected.
Configuration menu - View commit details
-
Copy full SHA for 9f03fa1 - Browse repository at this point
Copy the full SHA 9f03fa1View commit details -
Reword: GeoIP2 means something specific
and use a more general term instead. Maxmind seems to consistently refer to the GeoLite2 databases as 'GeoLite2 databases' and to their commercial offerings as 'GeoIP2 databases' -- both of them are 'IP geolocation databases' (which appears to me to be a generic term that applies to both their free and commercial databases as well as the things that others in the industry might provide).
Configuration menu - View commit details
-
Copy full SHA for 1195d2d - Browse repository at this point
Copy the full SHA 1195d2dView commit details -
We don't 'ship with' any databases
nor are any 'included in the module'.
Configuration menu - View commit details
-
Copy full SHA for 055d08c - Browse repository at this point
Copy the full SHA 055d08cView commit details -
Configuration menu - View commit details
-
Copy full SHA for e96905b - Browse repository at this point
Copy the full SHA e96905bView commit details -
Configuration menu - View commit details
-
Copy full SHA for ec27601 - Browse repository at this point
Copy the full SHA ec27601View commit details -
Configuration menu - View commit details
-
Copy full SHA for 736807e - Browse repository at this point
Copy the full SHA 736807eView commit details -
Configuration menu - View commit details
-
Copy full SHA for a69634f - Browse repository at this point
Copy the full SHA a69634fView commit details
Commits on Apr 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e9ccc8a - Browse repository at this point
Copy the full SHA e9ccc8aView commit details -
Configuration menu - View commit details
-
Copy full SHA for c9934f5 - Browse repository at this point
Copy the full SHA c9934f5View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.