Handle exceptions thrown by HTTP header validation #107355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today if the HTTP header validation throws an exception (rather than calling `listener.onFailure()`) then we treat this as a server-side error, record it in the logs, and close the connection abruptly without sending a response. In practice such an exception is more likely a client-side error, so with this commit we catch it and marshal it back to the client instead. Closes elastic#107338
DaveCTurner
added
>bug
:Distributed/Network
|
Pinging @elastic/es-distributed (Team:Distributed) |
|
Hi @DaveCTurner, I've created a changelog YAML for you. |
DaveCTurner
added
the
auto-merge
DaveCTurner
deleted the
2024/04/11/Netty4HttpHeaderValidator-validation-exception
branch
💚 Backport successful
|
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Apr 15, 2024
Today if the HTTP header validation throws an exception (rather than calling `listener.onFailure()`) then we treat this as a server-side error, record it in the logs, and close the connection abruptly without sending a response. In practice such an exception is more likely a client-side error, so with this commit we catch it and marshal it back to the client instead. Closes elastic#107338
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 15, 2024
Today if the HTTP header validation throws an exception (rather than calling `listener.onFailure()`) then we treat this as a server-side error, record it in the logs, and close the connection abruptly without sending a response. In practice such an exception is more likely a client-side error, so with this commit we catch it and marshal it back to the client instead. Closes #107338
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today if the HTTP header validation throws an exception (rather than
calling
listener.onFailure()) then we treat this as a server-sideerror, record it in the logs, and close the connection abruptly without
sending a response. In practice such an exception is more likely a
client-side error, so with this commit we catch it and marshal it back
to the client instead.
Closes #107338