Percolator named queries: rewrite for matched info #107432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR elastic#103084 introduced an ability to return matched_queries during percolate process for all percolator queries containing `_name` field. But there was a bug with complex queries, as they were not rewritten before obraining their Weight function. This fixes the bug by ensuring all queries are first rewritten. Closes elastic#107176
mayya-sharipova
added
>bug
:Search/Highlighting
|
Pinging @elastic/es-search (Team:Search) |
|
Hi @mayya-sharipova, I've created a changelog YAML for you. |
benwtrent
approved these changes
Apr 12, 2024
|
@elasticmachine run docs-build |
mayya-sharipova
added a commit
to mayya-sharipova/elasticsearch
that referenced
this pull request
Apr 12, 2024
PR elastic#103084 introduced an ability to return matched_queries during percolate process for all percolator queries containing `_name` field. But there was a bug with complex queries, as they were not rewritten before obraining their Weight function. This fixes the bug by ensuring all queries are first rewritten. Closes elastic#107176
mayya-sharipova
added a commit
to mayya-sharipova/elasticsearch
that referenced
this pull request
Apr 12, 2024
PR elastic#103084 introduced an ability to return matched_queries during percolate process for all percolator queries containing `_name` field. But there was a bug with complex queries, as they were not rewritten before obraining their Weight function. This fixes the bug by ensuring all queries are first rewritten. Closes elastic#107176
mayya-sharipova
added a commit
that referenced
this pull request
Apr 12, 2024
PR #103084 introduced an ability to return matched_queries during percolate process for all percolator queries containing `_name` field. But there was a bug with complex queries, as they were not rewritten before obraining their Weight function. This fixes the bug by ensuring all queries are first rewritten. Backfort for #107432 Closes #107176
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #103084 introduced an ability to return matched_queries during percolate
process for all percolator queries containing
_namefield.But there was a bug with complex queries, as they were not rewritten before
obtaining their Weight function. This fixes the bug by ensuring all queries are
first rewritten.
Closes #107176