[ML] External inference service rolling upgrade tests #107619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidkyle
added
>test
|
Pinging @elastic/ml-core (Team:ML) |
jonathan-buttner
approved these changes
Apr 18, 2024
| } | ||
|
|
||
| @SuppressWarnings("unchecked") | ||
| @AwaitsFix(bugUrl = "Cannot set the URL in the tests") |
There was a problem hiding this comment.
Yeah that's a bummer, is there a way to set some config flag for a test build of elasticsearch that we can then expose a url field? That way in production builds we won't allow it
...pgrade/src/javaRestTest/java/org/elasticsearch/xpack/application/CohereServiceUpgradeIT.java
Show resolved
Hide resolved
...pgrade/src/javaRestTest/java/org/elasticsearch/xpack/application/CohereServiceUpgradeIT.java
Show resolved
Hide resolved
...lasticsearch/xpack/inference/services/openai/embeddings/OpenAiEmbeddingsServiceSettings.java
Show resolved
Hide resolved
mark-vieira
reviewed
Apr 18, 2024
...e/src/javaRestTest/java/org/elasticsearch/xpack/application/AzureOpenAiServiceUpgradeIT.java
Show resolved
Hide resolved
davidkyle
commented
Apr 18, 2024
| } | ||
|
|
||
| @SuppressWarnings("unchecked") | ||
| @AwaitsFix(bugUrl = "Cannot set the URL in the tests") |
There was a problem hiding this comment.
The Azure OpenAI config does not allow a user settable URL which means it can't be tested with the mock web server. Either we enable that for these tests or find some other way of setting the URL
...pgrade/src/javaRestTest/java/org/elasticsearch/xpack/application/CohereServiceUpgradeIT.java
Show resolved
Hide resolved
...e/src/javaRestTest/java/org/elasticsearch/xpack/application/AzureOpenAiServiceUpgradeIT.java
Show resolved
Hide resolved
|
@elasticmachine update branch |
jonathan-buttner
approved these changes
Apr 24, 2024
|
@elasticmachine update branch |
davidkyle
added a commit
to davidkyle/elasticsearch
that referenced
this pull request
Apr 24, 2024
Rolling upgrade tests for OpenAI, Cohere and Hugging Face. The services are tested by setting the services' url to a local mock web server and mocking the responses.
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 25, 2024
#107868) * [ML] External inference service rolling upgrade tests (#107619) Rolling upgrade tests for OpenAI, Cohere and Hugging Face. The services are tested by setting the services' url to a local mock web server and mocking the responses. * fix compilation * Reduce inference rolling upgrade test parallelism --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Mark Vieira <portugee@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rolling upgrade tests for OpenAI, Azure, Cohere and Hugging Face. The services are tested by setting the services' url to a local mock web server and mocking the responses.
The tests exposed 1 issue for OpenAI where an older model that does not have the
dimensionsSetByUserfield throws an validation error.