Fix remover unit test #107711
Merged
Fix remover unit test #107711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfreden
force-pushed
the
fix_api_key_ci
branch
2 times, most recently
from
f978f65
to
c9ab4d2
Compare
jfreden
added
>test
|
Pinging @elastic/es-security (Team:Security) |
albertzaharovits
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #107699
When the api key remover did not run yet when the
waitForInactiveApiKeysRemoverTriggerReadyAndGetClientis called, the expected behaviour is that it will return any of the nodes in the internal test cluster. In #107602 the default value forlastRunwas updated from0to-1. This caused thewaitForInactiveApiKeysRemoverTriggerReadyAndGetClientto not select any node since the condition is> -1in the loop selecting a node.