[Data stream lifecycle]Add warning when the user's retention is not the effective retention #107781
Conversation
gmarouli
added
>non-issue
:Data Management/Data streams
elasticsearchmachine
added
the
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
server/src/main/java/org/elasticsearch/cluster/metadata/DataStreamLifecycle.java
Outdated
Show resolved
Hide resolved
...r/src/test/java/org/elasticsearch/cluster/metadata/DataStreamLifecycleWithWarningsTests.java
Outdated
Show resolved
Hide resolved
...r/src/test/java/org/elasticsearch/cluster/metadata/DataStreamLifecycleWithWarningsTests.java
Outdated
Show resolved
Hide resolved
|
|
||
| DataStreamLifecycle noRetentionLifecycle = DataStreamLifecycle.newBuilder().downsampling(randomDownsampling()).build(); | ||
| DataStreamGlobalRetention globalRetention = new DataStreamGlobalRetention( | ||
| randomTimeValue(2, 10, TimeUnit.DAYS), |
There was a problem hiding this comment.
Extremely minor nit: you sometimes use randomTimeValue(2, 10, TimeUnit.DAYS) and sometimes TimeValue.timeValueDays(randomIntBetween(5, 100)). I think it wouldn't hurt to stick to one for consistency's sake :). The former is slightly shorter than the latter, so maybe I have the tiniest preference for that, but I'll let it up to you 😉.
There was a problem hiding this comment.
You are right, and it's not an inconsistency, just trying to keep the PR manageable. randomTimeValue(2, 10, TimeUnit.DAYS) was recently introduced, so I use it now in the code I touch. Then in a separate PR I will change it because otherwise we are going to touch many other files.
There was a problem hiding this comment.
Ah okay that makes sense. I did notice one in this PR here, that's the only reason I mentioned it :).
server/src/main/java/org/elasticsearch/cluster/metadata/MetadataDataStreamsService.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/node/NodeConstruction.java
Outdated
Show resolved
Hide resolved
|
@elasticmachine update branch |
|
@elasticmachine update branch |
|
@elasticmachine update branch |
We want to inform the user when the retention provided in a data stream or a template is not going to be the effective retention.
We choose not to reject the configuration because:
Additionally, we add a warning header to inform the user about the effective retention.