[Transform] Halt Indexer on Stop/Abort API #107792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `_stop?wait_for_checkpoint=false` and `_stop?force=true&wait_for_checkpoint=false` are called, there is a small chance that the Transform Indexer thread will run if it is scheduled before the stop API is called but before the threadpool runs the executable. The `onStart` method now checks the state of the indexer before executing. This will mitigate errors caused by reading from Transform internal indices while the Task is stopped or deleted. This does not impact when `wait_for_checkpoint=true`, because the indexer state will remain `INDEXING` until the checkpoint is finished. Relate elastic#107266
|
Hi @prwhelan, I've created a changelog YAML for you. |
|
Pinging @elastic/ml-core (Team:ML) |
...n/transform/src/main/java/org/elasticsearch/xpack/transform/transforms/TransformIndexer.java
Show resolved
Hide resolved
...m/src/test/java/org/elasticsearch/xpack/transform/transforms/TransformIndexerStateTests.java
Outdated
Show resolved
Hide resolved
...m/src/test/java/org/elasticsearch/xpack/transform/transforms/TransformIndexerStateTests.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
_stop?wait_for_checkpoint=falseand_stop?force=true&wait_for_checkpoint=falseare called, there is a small chance that the Transform Indexer thread will run if it is scheduled before the stop API is called but before the threadpool runs the executable. TheonStartmethod now checks the state of the indexer before executing. This will mitigate errors caused by reading from Transform internal indices while the Task is stopped or deleted.This does not impact when
wait_for_checkpoint=true, because the indexer state will remainINDEXINGuntil the checkpoint is finished.Relate #107266