Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use LogDocMergePolicy in DiversifiedSamplerTests#testDiversifiedSampler #107826

Merged
merged 1 commit into from Apr 24, 2024

Conversation

iverase
Copy link
Contributor

@iverase iverase commented Apr 24, 2024

Similar to tother cases, the addition of a new merge policy that reverse the order of the documents in lucene causes this test to fail in edge cases. To avoid randomisation we hardcode the merge policy to LogDocMergePolicy.

fixes #107274

@iverase iverase added >test Issues or PRs that are addressing/adding tests :Analytics/Aggregations Aggregations v8.14.1 v8.15.0 labels Apr 24, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Apr 24, 2024
@iverase iverase merged commit c008039 into elastic:main Apr 24, 2024
14 checks passed
@iverase iverase deleted the DiversifiedSamplerTests branch April 24, 2024 12:36
@iverase iverase added the auto-backport-and-merge Automatically create backport pull requests and merge when ready label Apr 24, 2024
iverase added a commit to iverase/elasticsearch that referenced this pull request Apr 24, 2024
…er (elastic#107826)

Similar to tother cases, the addition of a new merge policy that reverse the order of the documents in lucene causes 
this test to fail in edge cases. To avoid randomisation we hardcode the merge policy to LogDocMergePolicy.
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.14

elasticsearchmachine pushed a commit that referenced this pull request Apr 24, 2024
…er (#107826) (#107835)

Similar to tother cases, the addition of a new merge policy that reverse the order of the documents in lucene causes 
this test to fail in edge cases. To avoid randomisation we hardcode the merge policy to LogDocMergePolicy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Aggregations Aggregations auto-backport-and-merge Automatically create backport pull requests and merge when ready Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v8.14.1 v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] DiversifiedSamplerTests testDiversifiedSampler failing
3 participants