[8.14] ESQL: Fix MV_DEDUPE when using data from an index (#107577) #107850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correctly label numerical/boolean blocks loaded from indices, so that MV_DEDUPE works correctly. (cherry picked from commit 70cfe6f) # Conflicts: # server/src/main/java/org/elasticsearch/TransportVersions.java # x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/plugin/EsqlFeatures.java
alex-spies
commented
Apr 24, 2024
Comment on lines
178
to
185
| public static final TransportVersion WATERMARK_THRESHOLDS_STATS = def(8_637_00_0); | ||
| public static final TransportVersion ENRICH_CACHE_ADDITIONAL_STATS = def(8_638_00_0); | ||
| public static final TransportVersion ML_INFERENCE_RATE_LIMIT_SETTINGS_ADDED = def(8_639_00_0); | ||
| public static final TransportVersion ML_TRAINED_MODEL_CACHE_METADATA_ADDED = def(8_640_00_0); | ||
| public static final TransportVersion TOP_LEVEL_KNN_SUPPORT_QUERY_NAME = def(8_641_00_0); | ||
| public static final TransportVersion INDEX_SEGMENTS_VECTOR_FORMATS = def(8_642_00_0); | ||
| public static final TransportVersion ADD_RESOURCE_ALREADY_UPLOADED_EXCEPTION = def(8_643_00_0); | ||
| public static final TransportVersion ESQL_MV_ORDERING_SORTED_ASCENDING = def(8_644_00_0); |
There was a problem hiding this comment.
Uh-oh, this backport would require to add capabilities to act on transport versions that are not yet handled in 8.14. I think this cannot work like that.
There was a problem hiding this comment.
Fixed by not using SORTED_ASCENDING, instead labelling with UNORDERED.
Adapt this fix so that we do not have to introduce SORTED_ASCENDING, and thus do not have to bump the transport version for this to work. Boolean/numerical doc values are just labelled as UNORDERED, instead, which is still correct.
nik9000
approved these changes
Apr 24, 2024
alex-spies
added
the
auto-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.14:In contrast to the original pull request, label boolean/numerical blocks with
MvOrdering.UNORDEREDrather thanSORTED_ASCENDING. This is still correct and avoids requiring to bump the transport version for this backport.