ESQL: Add aggregates node level reduction #107876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…add_node_reduction
elasticsearchmachine
added
needs:triage
|
@elasticmachine update branch |
astefan
added
>enhancement
:Analytics/ES|QL
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
Hi @astefan, I've created a changelog YAML for you. |
|
@elasticmachine update branch |
|
@elasticmachine run elasticsearch-ci/bwc-snapshots |
|
@elasticmachine run elasticsearch-ci/8.15.0 / bwc-snapshots |
|
@elasticmachine update branch |
dnhatn
approved these changes
Apr 25, 2024
| aggregatorMode = AggregatorMode.INITIAL; | ||
| } | ||
| } else { | ||
| aggregatorMode = AggregatorMode.INITIAL; |
There was a problem hiding this comment.
Should this be AggregatorMode.SINGLE instead? Can we assert false: ... here since we shouldn't reach this point in our current code base.
nik9000
reviewed
Apr 25, 2024
| if (mode == AggregateExec.Mode.FINAL) { | ||
| aggregatorMode = AggregatorMode.FINAL; | ||
| } else if (mode == AggregateExec.Mode.PARTIAL) { | ||
| if (aggregateExec.child() instanceof ExchangeSourceExec) {// the reducer step at data node (local) level |
There was a problem hiding this comment.
I feel like there should be a better way to plug this in. This feels like it'd break in a sneaky way one day.
There was a problem hiding this comment.
Yes, we can add a new aggregation mode.
…add_node_reduction
…add_node_reduction
…icsearch into add_node_reduction
markjhoy
pushed a commit
to markjhoy/elasticsearch
that referenced
this pull request
May 9, 2024
* Add aggregation intermediate reduction level and estimatedRowSize computed value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the remaining aggregate node-level reduction, following #106516.
Also, it estimates the row size for TopN and Aggregate node-level reduction plans.