Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lingering license warning header #108031

Merged

Conversation

albertzaharovits
Copy link
Contributor

Fixes the AcceptChannelHandler#accept mucking with the netty worker thread context.

Fixes #107573

@albertzaharovits albertzaharovits added >bug :Security/License License functionality for commercial features labels Apr 29, 2024
@albertzaharovits albertzaharovits self-assigned this Apr 29, 2024
@albertzaharovits albertzaharovits marked this pull request as ready for review April 29, 2024 16:21
@elasticsearchmachine elasticsearchmachine added v8.15.0 Team:Security Meta label for security team labels Apr 29, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

@elasticsearchmachine
Copy link
Collaborator

Hi @albertzaharovits, I've created a changelog YAML for you.

Copy link
Contributor

@Tim-Brooks Tim-Brooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slobodanadamovic slobodanadamovic added the auto-backport-and-merge Automatically create backport pull requests and merge when ready label May 2, 2024
@slobodanadamovic slobodanadamovic merged commit cf1f83f into elastic:main May 2, 2024
20 checks passed
albertzaharovits added a commit to albertzaharovits/elasticsearch that referenced this pull request May 2, 2024
Fixes the `AcceptChannelHandler#accept` mucking with the netty worker thread context.

Fixes elastic#107573
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.14
8.13 Commit could not be cherrypicked due to conflicts
7.17 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 108031

elasticsearchmachine pushed a commit that referenced this pull request May 2, 2024
Fixes the `AcceptChannelHandler#accept` mucking with the netty worker thread context.

Fixes #107573
slobodanadamovic pushed a commit to slobodanadamovic/elasticsearch that referenced this pull request May 2, 2024
Fixes the `AcceptChannelHandler#accept` mucking with the netty worker thread context.

Fixes elastic#107573

(cherry picked from commit cf1f83f)

# Conflicts:
#	modules/transport-netty4/src/test/java/org/elasticsearch/http/netty4/Netty4HttpServerTransportTests.java
@albertzaharovits albertzaharovits deleted the fix-lingering-license-error branch May 7, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport-and-merge Automatically create backport pull requests and merge when ready >bug :Security/License License functionality for commercial features Team:Security Meta label for security team v7.17.22 v8.14.1 v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lingering license warning response headers
4 participants