-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement lazy rollover for failure stores #108108
Merged
nielsbauman
merged 16 commits into
elastic:main
from
nielsbauman:failure-store-lazy-rollover
May 24, 2024
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
c10f579
Implement lazy rollover for failure stores
nielsbauman 52bb6ba
Add acknowledged checks
nielsbauman 703d1cd
Merge branch 'main' into failure-store-lazy-rollover
nielsbauman 50e0806
Process PR feedback
nielsbauman d6e0661
Fix condition
nielsbauman 5478df9
Fix test
nielsbauman 24331a7
Merge branch 'main' into failure-store-lazy-rollover
nielsbauman a957855
Avoid unnecessary map creation
nielsbauman 6b377be
Feedback
nielsbauman 3b6a10a
Fix requireAlias logic
nielsbauman 34f6890
Remove TODO
nielsbauman c3b9816
Merge branch 'main' into failure-store-lazy-rollover
nielsbauman 06c8b26
Remove node feature
nielsbauman 8100ba3
Conditinally declare capability
nielsbauman 3093ea4
Merge branch 'main' into failure-store-lazy-rollover
nielsbauman 83c9164
Feedback
nielsbauman File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thecoop @rjernst I wonder if we should add this by default for all YAML test projects as I assume it's necessary if you use any capabilities-based
requires
conditions?