Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nicer exception when no scroll ID is provided #10813

Closed
wants to merge 3 commits into from
Closed

Nicer exception when no scroll ID is provided #10813

wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 26, 2015

rjernst
rjernst reviewed Apr 29, 2015
View reviewed changes
src/main/java/org/elasticsearch/action/search/type/TransportSearchHelper.java
@@ -62,7 +63,7 @@ public static String buildScrollId(SearchType searchType, AtomicArray<? extends
} else if (searchType == SearchType.SCAN) {
return buildScrollId(ParsedScrollId.SCAN, searchPhaseResults, attributes);
} else {
throw new ElasticsearchIllegalStateException("search_type [" + searchType + "] not supported");
throw new ElasticsearchIllegalStateException();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should have an empty exception message?

@rjernst
Copy link
Member

rjernst commented Apr 29, 2015

@Myll I left some comments.

@ghost
Copy link
Author

ghost commented Apr 29, 2015

@rjernst okay, fixed

rjernst
rjernst reviewed Apr 29, 2015
View reviewed changes
src/main/java/org/elasticsearch/action/search/type/TransportSearchHelper.java
@@ -39,6 +39,7 @@
import org.elasticsearch.search.internal.ShardSearchTransportRequest;

import java.io.IOException;
import java.util.Arrays;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leftover import

@rjernst
Copy link
Member

rjernst commented Apr 29, 2015

@Myll Can you remove the leftover import and rebase?

@clintongormley
Copy link

Hi @stephenfournier

Any chance you want to pick this up again, or should we take it over?

@clintongormley
Copy link

No further feedback. Closing

@clintongormley clintongormley mentioned this pull request Oct 8, 2016
Closed
@clintongormley clintongormley added :Search/Search Search-related issues that do not fall into other categories and removed :Scroll labels Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
>enhancement feedback_needed :Search/Search Search-related issues that do not fall into other categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rjernst @clintongormley