[ML] Replace objects with primitives in Text Embedding Results classes #108161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @maxhniebergall, I've created a changelog YAML for you. |
…astic/elasticsearch into textEmbeddingResultPrimitives # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
|
@elasticmachine update branch |
# Conflicts: # x-pack/plugin/inference/qa/test-service-plugin/src/main/java/org/elasticsearch/xpack/inference/mock/TestDenseInferenceServiceExtension.java
…astic/elasticsearch into textEmbeddingResultPrimitives
maxhniebergall
changed the title
|
Pinging @elastic/ml-core (Team:ML) |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
maxhniebergall
requested review from
jonathan-buttner and
davidkyle
and removed request for
jonathan-buttner
...ain/java/org/elasticsearch/xpack/core/inference/results/ChunkedTextEmbeddingByteResults.java
Show resolved
Hide resolved
...g/elasticsearch/xpack/inference/external/response/cohere/CohereEmbeddingsResponseEntity.java
Outdated
Show resolved
Hide resolved
…astic/elasticsearch into textEmbeddingResultPrimitives
# Conflicts: # x-pack/plugin/inference/qa/test-service-plugin/src/main/java/org/elasticsearch/xpack/inference/mock/TestDenseInferenceServiceExtension.java
jonathan-buttner
approved these changes
May 16, 2024
docs/changelog/108161.yaml
Outdated
| @@ -0,0 +1,5 @@ | |||
| pr: 108161 | |||
| summary: Tests pass | |||
There was a problem hiding this comment.
hmm, how about instead of the label >bug which generates this, we do >non-issue, >tech-debt? I haven't used tech debt before but we probably don't need a change log for this.
There was a problem hiding this comment.
seems like we still got a changelog, but I updated it to have a more accurate summary
There was a problem hiding this comment.
using >tech-debt seems to have failed the build
|
Hi @maxhniebergall, I've updated the changelog YAML for you. |
|
Hi @maxhniebergall, I've updated the changelog YAML for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace objects with primitives in Text Embedding Results classes.
Verified that the new mixed cluster tests passed.