-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make translog fsync configurable #108242
Make translog fsync configurable #108242
Conversation
Pinging @elastic/es-distributed (Team:Distributed) |
@@ -1929,7 +1930,8 @@ public static String createEmptyTranslog( | |||
}, | |||
BigArrays.NON_RECYCLING_INSTANCE, | |||
DiskIoBufferPool.INSTANCE, | |||
(d, s, l) -> {} | |||
TranslogConfig.NOOP_OPERATION_LISTENER, | |||
true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Empty translog is always fsynced. Not sure if it is important to make it configurable as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable, we can tackle that independently if we see it pop up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@@ -1929,7 +1930,8 @@ public static String createEmptyTranslog( | |||
}, | |||
BigArrays.NON_RECYCLING_INSTANCE, | |||
DiskIoBufferPool.INSTANCE, | |||
(d, s, l) -> {} | |||
TranslogConfig.NOOP_OPERATION_LISTENER, | |||
true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable, we can tackle that independently if we see it pop up.
This change introduces
fsync
property onTranslogConfig
object.This property allows to disable fsyncs. This might be useful if translog is backed up by another persistent storage.
Related to: ES-8430