Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable inter-segment concurrency for low cardinality numeric terms aggs #108306

Merged
merged 3 commits into from
May 20, 2024

Conversation

iverase
Copy link
Contributor

@iverase iverase commented May 6, 2024

This commit enables inter-segment search concurrency for numeric terms aggs over long, integer and short field types. It estimates the cardinality by computing the min and max value of the shard using the BKD tree. When the estimated cardinality of the field being aggregated on is lower than the shard size then inter-segment concurrency is enabled.

@iverase iverase requested a review from javanna May 6, 2024 11:45
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label May 6, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine
Copy link
Collaborator

Hi @iverase, I've created a changelog YAML for you.

Copy link
Member

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. assuming existing tests provide the necessary coverage.

@iverase
Copy link
Contributor Author

iverase commented May 17, 2024

@elasticmachine update branch

@iverase iverase merged commit ba0073a into elastic:main May 20, 2024
15 checks passed
@iverase iverase deleted the num_terms branch May 20, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Aggregations Aggregations >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants