Fix Netty4HttpServerTransportTests testChannelAcceptorCannotTamperThreadContext #108374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertzaharovits
added
>test
albertzaharovits
commented
May 7, 2024
| @@ -568,11 +568,9 @@ public void dispatchBadRequest(final RestChannel channel, final ThreadContext th | |||
| } | |||
| }; | |||
| // there's only one netty worker thread that's reused across client requests | |||
| Settings settings = Settings.builder() | |||
| .put(Netty4Plugin.WORKER_COUNT.getKey(), 1) | |||
| Settings settings = createBuilderWithPort().put(Netty4Plugin.WORKER_COUNT.getKey(), 1) | |||
There was a problem hiding this comment.
I think this is the problem. I think the error we're seeing in #108193 is an exception due to an RST state for the socket.
There was a problem hiding this comment.
You are right. Funnily, this was the first thing I tried. Not sure why it failed for me before, but I re-tested it now and it passes without exceptions.
albertzaharovits
commented
May 7, 2024
| for (int i = 0; i < nRetries; i++) { | ||
| acceptChannel.set(randomBoolean()); | ||
| try (Netty4HttpClient client = new Netty4HttpClient()) { | ||
| try (Netty4HttpClient client = new Netty4HttpClient()) { |
There was a problem hiding this comment.
Alternatively, I think it's "better" to reuse the client. If there is context pollution, it will first show up across different requests from the same client, before leaking across clients (because clients are statically assigned to a single thread).
albertzaharovits
commented
May 7, 2024
| .put(Netty4Plugin.SETTING_HTTP_WORKER_COUNT.getKey(), 0) | ||
| .build(); | ||
| NioEventLoopGroup group = new NioEventLoopGroup(); |
There was a problem hiding this comment.
This was not used.
albertzaharovits
deleted the
fix-testChannelAcceptorCannotTamperThreadContext
branch
albertzaharovits
added a commit
to albertzaharovits/elasticsearch
that referenced
this pull request
May 8, 2024
…eadContext (elastic#108374) Fix Netty4HttpServerTransportTests testChannelAcceptorCannotTamperThreadContext
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Netty4HttpServerTransportTests testChannelAcceptorCannotTamperThreadContext
Closes #108193