Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apm-data: ignore malformed fields, and too many dynamic fields #108444

Merged
merged 2 commits into from
May 9, 2024

Conversation

axw
Copy link
Member

@axw axw commented May 9, 2024

Enable ignore_malformed on all non-metrics APM data streams, and enable ignore_dynamic_beyond_limit for all APM data streams. We can enable ignore_malformed on metrics data streams when #90007 is fixed.

This change means that instead of outright rejecting documents, we will index the documents without indexing those particular malformed fields or dynamic fields exceeding the field limit; these fields will be listed in the _ignored meta-field.

Enable ignore_malformed on all non-metrics APM data streams,
and enable ignore_dynamic_beyond_limit for all APM data streams.

We can enable ignore_malformed on metrics data streams when
elastic#90007 is fixed.
@axw axw added >enhancement :Data Management/Data streams Data streams and their lifecycles labels May 9, 2024
@axw axw requested a review from a team as a code owner May 9, 2024 03:06
@elasticsearchmachine elasticsearchmachine added v8.15.0 Team:Data Management Meta label for data/management team labels May 9, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@elasticsearchmachine
Copy link
Collaborator

Hi @axw, I've created a changelog YAML for you.

Copy link

@marclop marclop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Will Elasticsearch still return 400 for the documents that have malformed/incorrect fields?

@axw
Copy link
Member Author

axw commented May 9, 2024

@axw axw merged commit 05d5abe into elastic:main May 9, 2024
15 checks passed
@axw axw deleted the apmdata-ignore_malformed_field_limit branch May 9, 2024 07:33
markjhoy pushed a commit to markjhoy/elasticsearch that referenced this pull request May 9, 2024
…ic#108444)

* apm-data: ignore_{malformed,dynamic_beyond_limit}

Enable ignore_malformed on all non-metrics APM data streams,
and enable ignore_dynamic_beyond_limit for all APM data streams.

We can enable ignore_malformed on metrics data streams when
elastic#90007 is fixed.

* Update docs/changelog/108444.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Data streams Data streams and their lifecycles >enhancement Team:Data Management Meta label for data/management team v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants