[ES|QL] Convert string to datetime when the other size of an arithmetic operator is date_period or time_duration

[fang-xing-esql]

Resolves : #108432

eval x = 1 day + "2024-01-01" this will work after this change. Users don't need to call to_dt explicitly like this eval x = 1 day + to_dt("2024-01-01")

[elasticsearchmachine]

Pinging @elastic/es-analytical-engine (Team:Analytics)

[elasticsearchmachine]

Hi @fang-xing-esql, I've created a changelog YAML for you.

[alex-spies]

Thanks @fang-xing-esql , looks good!

I'd increase test coverage a bit, though; maybe we could also add an analyzer/verifier test that confirms that arbitrary functions producing a (foldable) string can't be used, so that e.g. mv_concat("2024", "-04", "-01") + 1 day is invalid.

[elasticsearchmachine]

Pinging @elastic/kibana-esql (ES|QL-ui)

[fang-xing-esql]

Thanks @fang-xing-esql , looks good!

I'd increase test coverage a bit, though; maybe we could also add an analyzer/verifier test that confirms that arbitrary functions producing a (foldable) string can't be used, so that e.g. mv_concat("2024", "-04", "-01") + 1 day is invalid.

Thanks for reviewing @alex-spies ! More tests are added as suggested.

[alex-spies]

Thanks @fang-xing-esql, looking good!

Tiny suggestion for one more test, but this is already good to go as-is.

[costin]

LGTM

[fang-xing-esql]

@costin @astefan @bpintea Could you help take another look at this? Thank you!

[bpintea]

Lgtm.
I'd add two more tests (on top of all suggested ones): temporal ± string ± temporal and the other way around, string ± temporal ± string

[fang-xing-esql]

Thanks for reviewing @costin @bpintea @alex-spies ! Just need to clean up CI.